Skip to content

feat(api): add merge trains #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

JacobHenner
Copy link
Contributor

Add support for merge trains

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #1646 (d4bbacb) into main (5a1678f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   91.90%   91.94%   +0.03%     
==========================================
  Files          74       75       +1     
  Lines        4287     4308      +21     
==========================================
+ Hits         3940     3961      +21     
  Misses        347      347              
Flag Coverage Δ
cli_func_v4 81.98% <100.00%> (+0.08%) ⬆️
py_func_v4 81.01% <100.00%> (+0.09%) ⬆️
unit 83.79% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/merge_trains.py 100.00% <100.00%> (ø)
gitlab/v4/objects/projects.py 86.78% <100.00%> (+0.09%) ⬆️
gitlab/v4/objects/runners.py 98.18% <0.00%> (ø)
gitlab/v4/objects/users.py 98.50% <0.00%> (+0.06%) ⬆️

Add support for merge trains
@JacobHenner
Copy link
Contributor Author

Hello - this should be set to go. Let me know if any additional changes are required.

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JacobHenner sorry this slipped!

@nejch nejch merged commit ed88bce into python-gitlab:main Nov 1, 2021
@JacobHenner
Copy link
Contributor Author

Thanks @JacobHenner sorry this slipped!

No problem at all, just wanted to make sure I hadn't forgotten anything. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants