Skip to content

chore: enforce type-hints on most files in gitlab/v4/objects/ #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2021
Merged

chore: enforce type-hints on most files in gitlab/v4/objects/ #1680

merged 1 commit into from
Nov 8, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Nov 8, 2021 •
edited
Loading

  • Add type-hints to some of the files in gitlab/v4/objects/
  • Fix issues detected when adding type-hints
  • Changed mypy exclusion to explicitly list the 13 files that have
    not yet had type-hints added.

@JohnVillalovos JohnVillalovos requested a review from nejch November 8, 2021 05:12
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_small_files_1 branch from 68cafa0 to 59d1bde Compare November 8, 2021 05:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021 •
edited
Loading

Codecov Report

Merging #1680 (59d1bde) into main (0e6fb5e) will decrease coverage by 0.08%.
The diff coverage is 89.02%.

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   91.95%   91.86%   -0.09%     
==========================================
  Files          75       75              
  Lines        4364     4427      +63     
==========================================
+ Hits         4013     4067      +54     
- Misses        351      360       +9
Flag Coverage Δ
cli_func_v4 81.65% <69.51%> (-0.20%) ⬇️
py_func_v4 81.16% <82.92%> (-0.03%) ⬇️
unit 83.60% <79.26%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/client.py 89.79% <ø> (ø)
gitlab/v4/cli.py 81.20% <ø> (ø)
gitlab/v4/objects/packages.py 96.15% <ø> (ø)
gitlab/v4/objects/boards.py 90.47% <55.55%> (-9.53%) ⬇️
gitlab/v4/objects/push_rules.py 92.85% <66.66%> (-7.15%) ⬇️
gitlab/v4/objects/export_import.py 94.59% <77.77%> (-5.41%) ⬇️
gitlab/v4/objects/wikis.py 96.42% <80.00%> (-3.58%) ⬇️
gitlab/v4/objects/deploy_keys.py 96.29% <83.33%> (-3.71%) ⬇️
gitlab/v4/objects/appearance.py 100.00% <100.00%> (ø)
gitlab/v4/objects/badges.py 100.00% <100.00%> (ø)
... and 11 more

nejch
nejch reviewed Nov 8, 2021
View reviewed changes
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_small_files_1 branch from 59d1bde to 5523f6a Compare November 8, 2021 15:19
@JohnVillalovos
chore: enforce type-hints on most files in gitlab/v4/objects/
7828ba2 
  * Add type-hints to some of the files in gitlab/v4/objects/
  * Fix issues detected when adding type-hints
  * Changed mypy exclusion to explicitly list the 13 files that have
    not yet had type-hints added.
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_small_files_1 branch from 5523f6a to 7828ba2 Compare November 8, 2021 15:21
nejch
nejch approved these changes Nov 8, 2021
View reviewed changes
@nejch nejch merged commit 472b300 into main Nov 8, 2021
@nejch nejch deleted the jlvillal/mypy_small_files_1 branch November 8, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @codecov-commenter @nejch