Skip to content

feat: add support for projects.groups.list() #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Nov 26, 2021

Add support for projects.groups.list() endpoint.

Closes #1590

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/project_groups branch 2 times, most recently from d562c3f to 979053c Compare November 26, 2021 20:06
@JohnVillalovos JohnVillalovos changed the title WIP: Add support for projects.groups.* fix: add support for projects.groups.* Nov 26, 2021
@JohnVillalovos JohnVillalovos marked this pull request as draft November 26, 2021 20:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #1718 (68ff595) into main (8d4c953) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
+ Coverage   91.49%   91.50%   +0.01%     
==========================================
  Files          75       75              
  Lines        4630     4639       +9     
==========================================
+ Hits         4236     4245       +9     
  Misses        394      394              
Flag Coverage Δ
cli_func_v4 80.66% <100.00%> (+0.03%) ⬆️
py_func_v4 80.92% <100.00%> (+0.03%) ⬆️
unit 82.94% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/projects.py 87.19% <100.00%> (+0.41%) ⬆️

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/project_groups branch 9 times, most recently from 13755d8 to 421a4ae Compare November 27, 2021 00:25
@JohnVillalovos JohnVillalovos changed the title fix: add support for projects.groups.* fix: add support for projects.groups.list() Nov 27, 2021
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/project_groups branch 2 times, most recently from 11c429c to d28cca0 Compare November 27, 2021 00:38
@JohnVillalovos JohnVillalovos changed the title fix: add support for projects.groups.list() feat: add support for projects.groups.list() Nov 27, 2021
Add support for `projects.groups.list()` endpoint.

Closes #1717
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/project_groups branch from d28cca0 to 68ff595 Compare November 27, 2021 04:20
@JohnVillalovos JohnVillalovos marked this pull request as ready for review November 27, 2021 04:21
@nejch nejch merged commit 64f2360 into main Nov 27, 2021
@nejch nejch deleted the jlvillal/project_groups branch November 27, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is /projects/:id/groups implemented
3 participants