Skip to content

chore(objects): use self.encoded_id where could be a string #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

chore(objects): use self.encoded_id where could be a string #1835

merged 1 commit into from
Jan 14, 2022

Conversation

JohnVillalovos
Copy link
Member

Updated a few remaining usages of self.id to use self.encoded_id
where it could be a string value.

@JohnVillalovos
chore(objects): use self.encoded_id where could be a string
c3c3a91 
Updated a few remaining usages of `self.id` to use `self.encoded_id`
where it could be a string value.
@JohnVillalovos JohnVillalovos requested a review from nejch January 14, 2022 00:17
@nejch nejch enabled auto-merge January 14, 2022 00:19
@nejch nejch merged commit 34110dd into main Jan 14, 2022
@nejch nejch deleted the jlvillal/id_to_encodedid branch January 14, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnVillalovos @nejch