From 5b7d00df466c0fe894bafeb720bf94ffc8cd38fd Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 5 Feb 2022 11:13:31 -0800 Subject: [PATCH] test(functional): fix GitLab configuration to support pagination When pagination occurs python-gitlab uses the URL provided by the GitLab server to use for the next request. We had previously set the GitLab server configuraiton to say its URL was `http://gitlab.test` which is not in DNS. Set the hostname in the URL to `http://127.0.0.1:8080` which is the correct URL for the GitLab server to be accessed while doing functional tests. Closes: #1877 --- tests/functional/api/test_gitlab.py | 4 ++-- tests/functional/api/test_projects.py | 2 +- tests/functional/fixtures/docker-compose.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/api/test_gitlab.py b/tests/functional/api/test_gitlab.py index b0711280e..5c8cf854d 100644 --- a/tests/functional/api/test_gitlab.py +++ b/tests/functional/api/test_gitlab.py @@ -81,13 +81,13 @@ def test_template_dockerfile(gl): def test_template_gitignore(gl): - assert gl.gitignores.list() + assert gl.gitignores.list(all=True) gitignore = gl.gitignores.get("Node") assert gitignore.content is not None def test_template_gitlabciyml(gl): - assert gl.gitlabciymls.list() + assert gl.gitlabciymls.list(all=True) gitlabciyml = gl.gitlabciymls.get("Nodejs") assert gitlabciyml.content is not None diff --git a/tests/functional/api/test_projects.py b/tests/functional/api/test_projects.py index a66e3680e..8f8abbe86 100644 --- a/tests/functional/api/test_projects.py +++ b/tests/functional/api/test_projects.py @@ -244,7 +244,7 @@ def test_project_protected_branches(project): def test_project_remote_mirrors(project): - mirror_url = "http://gitlab.test/root/mirror.git" + mirror_url = "https://gitlab.example.com/root/mirror.git" mirror = project.remote_mirrors.create({"url": mirror_url}) assert mirror.url == mirror_url diff --git a/tests/functional/fixtures/docker-compose.yml b/tests/functional/fixtures/docker-compose.yml index e4869fbe0..ae1d77655 100644 --- a/tests/functional/fixtures/docker-compose.yml +++ b/tests/functional/fixtures/docker-compose.yml @@ -14,7 +14,7 @@ services: GITLAB_ROOT_PASSWORD: 5iveL!fe GITLAB_SHARED_RUNNERS_REGISTRATION_TOKEN: registration-token GITLAB_OMNIBUS_CONFIG: | - external_url 'http://gitlab.test' + external_url 'http://127.0.0.1:8080' registry['enable'] = false nginx['redirect_http_to_https'] = false nginx['listen_port'] = 80