test: increase projects coverage #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
+ Coverage 92.58% 92.66% +0.07%
==========================================
Files 78 78
Lines 4938 4949 +11
==========================================
+ Hits 4572 4586 +14
+ Misses 366 363 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
May 8, 2022
There was a problem hiding this comment.
Thanks a lot for the PR @rnoberger. I've added the comments on how to reduce the fixture boilerplate as discussed, let me know if anything's unclear.
If applying the suggestions in the UI just make sure to change the commit message on GitHub or amend it later to match our convention :) Thanks!
0ba035b to
fa47829
Compare
nejch
approved these changes
May 10, 2022
There was a problem hiding this comment.
Thank you for working on this @rnoberger, let us know in case you want to continue working on other parts and need any help :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.