Skip to content

chore: enable mypy check disallow_any_generics #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2022
Merged

chore: enable mypy check disallow_any_generics #2211

merged 1 commit into from
Aug 1, 2022

Conversation

JohnVillalovos
Copy link
Member

No description provided.

@JohnVillalovos JohnVillalovos marked this pull request as draft August 1, 2022 07:26
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_step_step branch from 508d329 to ab9dfe4 Compare August 1, 2022 07:27
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_step_step branch from ab9dfe4 to 24d17b4 Compare August 1, 2022 07:29
@JohnVillalovos JohnVillalovos marked this pull request as ready for review August 1, 2022 07:31
@JohnVillalovos JohnVillalovos requested a review from nejch August 1, 2022 07:31
@codecov-commenter
Copy link

Codecov Report

Merging #2211 (24d17b4) into main (54dd4c3) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main    #2211      +/-   ##
==========================================
- Coverage   95.46%   95.44%   -0.02%     
==========================================
  Files          81       81              
  Lines        5353     5356       +3     
==========================================
+ Hits         5110     5112       +2     
- Misses        243      244       +1
Flag Coverage Δ
api_func_v4 81.40% <12.50%> (-0.05%) ⬇️
cli_func_v4 83.12% <62.50%> (-0.01%) ⬇️
unit 87.26% <62.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/mixins.py 92.05% <ø> (ø)
gitlab/utils.py 98.59% <ø> (ø)
gitlab/v4/objects/artifacts.py 100.00% <ø> (ø)
gitlab/v4/objects/packages.py 96.29% <ø> (ø)
gitlab/v4/objects/projects.py 100.00% <ø> (ø)
gitlab/v4/cli.py 90.52% <57.14%> (-0.26%) ⬇️
gitlab/client.py 98.71% <100.00%> (ø)

@nejch nejch merged commit 1136b17 into main Aug 1, 2022
@nejch nejch deleted the jlvillal/mypy_step_step branch August 1, 2022 08:12
@nejch nejch mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @codecov-commenter @nejch