-
Notifications
You must be signed in to change notification settings - Fork 668
chore: validate httpx package is not installed by default #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nejch @JohnVillalovos Is it possible the |
That new test seems to be flaky. Now who is responsible for that? /me checks So looks like I need to spend some more time making |
/rerun-all |
Can this be done using Doesn't have to be a default test that is run in |
Yup. I forgot to handle it via fox. Thanks for your feedback. |
7e1e7d9
to
5aa1690
Compare
@lmilbaum I probably won't have time to check this until next or the following week. Sorry. Holidays this week in the states and my work is keeping me busy too. I just wanted to let you know that I haven't forgotten. @nejch Feel free to go ahead without me if it you like it. No need to wait for my approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for digging into this @lmilbaum, this took a bit longer than we all expected but will be useful later when we probably use it with some parametrized request clients :)
No description provided.