Skip to content

test(api): fix flaky test test_cancel_merge_when_pipeline_succeeds #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Nov 19, 2022

This is an attempt to fix the flaky test
test_cancel_merge_when_pipeline_succeeds.
Were seeing a: 405 Method Not Allowed error when setting the MR to
merge_when_pipeline_succeeds.

Closes: #2383

@JohnVillalovos JohnVillalovos requested a review from nejch November 19, 2022 18:37
This is an attempt to fix the flaky test
`test_cancel_merge_when_pipeline_succeeds`.
Were seeing a: 405 Method Not Allowed error when setting the MR to
merge_when_pipeline_succeeds.

Closes: #2383
@JohnVillalovos JohnVillalovos changed the title test(api): fix flaky test test_merge_request_reset_approvals test(api): fix flaky test test_cancel_merge_when_pipeline_succeeds Nov 19, 2022
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohnVillalovos let's see if this helps!

@nejch nejch merged commit 6525c17 into main Nov 21, 2022
@nejch nejch deleted the jlvillal/flaky_test branch November 21, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API test test_cancel_merge_when_pipeline_succeeds is flaky
3 participants