Skip to content

feat: allow passing kwargs to Gitlab class when instantiating with from_config #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2022
Merged

feat: allow passing kwargs to Gitlab class when instantiating with from_config #2392

merged 1 commit into from
Dec 4, 2022

Conversation

lmilbaum
Copy link

@lmilbaum lmilbaum commented Nov 24, 2022 •
edited
Loading

This PR is needed for the validation of #2391

@lmilbaum lmilbaum force-pushed the custom_session branch 5 times, most recently from 62a8f03 to a815453 Compare November 24, 2022 06:36
@lmilbaum lmilbaum marked this pull request as ready for review November 24, 2022 06:50
@lmilbaum lmilbaum mentioned this pull request Nov 26, 2022
Merged
@nejch nejch mentioned this pull request Nov 26, 2022
Merged
nejch
nejch requested changes Nov 26, 2022
View reviewed changes
@lmilbaum lmilbaum force-pushed the custom_session branch 4 times, most recently from 6c962b0 to a2717a4 Compare November 26, 2022 20:23
@lmilbaum lmilbaum requested a review from nejch November 26, 2022 21:21
@nejch nejch changed the title feat: Generation of Gitlab class with custom requests session feat: allow passing kwargs to Gitlab class when instantiating with from_config Dec 4, 2022
@nejch nejch merged commit e88d34e into python-gitlab:main Dec 4, 2022
@lmilbaum lmilbaum deleted the custom_session branch December 5, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmilbaum @nejch