Skip to content

refactor: add reason property to RequestsResponse #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

refactor: add reason property to RequestsResponse #2439

merged 1 commit into from
Dec 21, 2022

Conversation

lmilbaum
Copy link

@lmilbaum lmilbaum commented Dec 20, 2022 •
edited
Loading

main is broken. This PR is fixing it.

@lmilbaum lmilbaum self-assigned this Dec 20, 2022
@lmilbaum
Copy link
Author

/rerun-all

nejch
nejch approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmilbaum. I'll reword this to a refactor or chore commit message as this has not yet been released and will not be a user-facing change for the changelog.

@nejch nejch changed the title fix: RequestsResponse was missing the reason function refactor: add reason property to RequestsResponse Dec 21, 2022
@nejch nejch merged commit b59b7bd into python-gitlab:main Dec 21, 2022
@lmilbaum lmilbaum deleted the fix branch December 21, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

@JohnVillalovos JohnVillalovos Awaiting requested review from JohnVillalovos

Assignees

@lmilbaum lmilbaum

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmilbaum @nejch