From 0f30a6f9d8247a5adb6efba55c855aa218f4c726 Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Tue, 14 May 2024 22:58:27 -0700 Subject: [PATCH] fix: handle large number of approval rules Use `iterator=True` when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules. Closes: #2825 --- gitlab/v4/objects/merge_request_approvals.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py index 4ff34e291..18c3e3780 100644 --- a/gitlab/v4/objects/merge_request_approvals.py +++ b/gitlab/v4/objects/merge_request_approvals.py @@ -122,7 +122,7 @@ def set_approvers( self._parent.approval_rules ) # update any existing approval rule matching the name - existing_approval_rules = approval_rules.list() + existing_approval_rules = approval_rules.list(iterator=True) for ar in existing_approval_rules: if ar.name == approval_rule_name: ar.user_ids = data["user_ids"]