Skip to content

Add support for searching groups #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for searching groups #55

wants to merge 2 commits into from

Conversation

dserodio
Copy link

It can probably be improved, but works for my needs

@ghost
Copy link

ghost commented Oct 17, 2015

I agree with you Gauvain. It would be nice if these kind of 'search' functions are implemented directly in the classes (like Group or project).

What do you think about this:

A special class to do queries (we will have the possibility to choose between):

  1. id=None, to list everything
  2. or GitlabQuery(), to add some rules
    projects = git.Project(GitlabQuery(name="projectname"))
    projects = git.Project(GitlabQuery(is_admin=True))

    groups = git.Group(GitlabQuery(name="groupname"))

gpocentek pushed a commit that referenced this pull request Jan 9, 2016
Add support for groups search
5513d0f 
Factorize the code to avoid duplication with the ProjectManager class.
Implement unit tests for the group search.

Original patchh from Daniel Serodio (PR #55).
@gpocentek
Copy link
Contributor

The code has changed recently and it's been easier to implement this method on the group manager. I pushed the change in commit 5513d0f. Thank you!

@gpocentek gpocentek closed this Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dserodio @gpocentek