From 53f7de7bfe0056950a8e7271632da3f89e3ba3b3 Mon Sep 17 00:00:00 2001
From: Joost Evertse <joustie@gmail.com>
Date: Mon, 14 Jan 2019 15:22:20 +0100
Subject: [PATCH] feat: Added approve & unapprove method for Mergerequests

Offical GitLab API supports this for GitLab EE
---
 gitlab/exceptions.py |  4 ++++
 gitlab/v4/objects.py | 41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+)

diff --git a/gitlab/exceptions.py b/gitlab/exceptions.py
index 6736f67db..ddaef3149 100644
--- a/gitlab/exceptions.py
+++ b/gitlab/exceptions.py
@@ -161,6 +161,10 @@ class GitlabMRForbiddenError(GitlabOperationError):
     pass
 
 
+class GitlabMRApprovalError(GitlabOperationError):
+    pass
+
+
 class GitlabMRClosedError(GitlabOperationError):
     pass
 
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
index 9327e06f7..fdd02aef8 100644
--- a/gitlab/v4/objects.py
+++ b/gitlab/v4/objects.py
@@ -2132,6 +2132,47 @@ def changes(self, **kwargs):
         path = '%s/%s/changes' % (self.manager.path, self.get_id())
         return self.manager.gitlab.http_get(path, **kwargs)
 
+    @cli.register_custom_action('ProjectMergeRequest', tuple(), ('sha'))
+    @exc.on_http_error(exc.GitlabMRApprovalError)
+    def approve(self, sha=None, **kwargs):
+        """Approve the merge request.
+
+        Args:
+            sha (str): Head SHA of MR
+            **kwargs: Extra options to send to the server (e.g. sudo)
+
+        Raises:
+            GitlabAuthenticationError: If authentication is not correct
+            GitlabMRApprovalError: If the approval failed
+        """
+        path = '%s/%s/approve' % (self.manager.path, self.get_id())
+        data = {}
+        if sha:
+            data['sha'] = sha
+
+        server_data = self.manager.gitlab.http_post(path, post_data=data,
+                                                    **kwargs)
+        self._update_attrs(server_data)
+
+    @cli.register_custom_action('ProjectMergeRequest')
+    @exc.on_http_error(exc.GitlabMRApprovalError)
+    def unapprove(self, **kwargs):
+        """Unapprove the merge request.
+
+        Args:
+            **kwargs: Extra options to send to the server (e.g. sudo)
+
+        Raises:
+            GitlabAuthenticationError: If authentication is not correct
+            GitlabMRApprovalError: If the unapproval failed
+        """
+        path = '%s/%s/unapprove' % (self.manager.path, self.get_id())
+        data = {}
+
+        server_data = self.manager.gitlab.http_post(path, post_data=data,
+                                                    **kwargs)
+        self._update_attrs(server_data)
+
     @cli.register_custom_action('ProjectMergeRequest', tuple(),
                                 ('merge_commit_message',
                                  'should_remove_source_branch',