Skip to content

fix: re-add merge request pipelines #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2019
Merged

fix: re-add merge request pipelines #689

merged 1 commit into from
Jan 26, 2019

Conversation

max-wittig
Copy link
Member

I'm sorry for the merge, but I noticed too late that #685 actually removed the merge request pipelines method. This re-adds it

@gpocentek
Copy link
Contributor

Eh, that happens :)

Could you just fix the pep8 failure?

@max-wittig
Copy link
Member Author

@gpocentek I'm not sure how to fix this pep8 warning.

gitlab/v4/objects.py:2292:1: H405  multi line docstring summary not separated with an empty line

@gpocentek
Copy link
Contributor

@max-wittig there were missing blank lines in the docstring, no big deal :)

I pushed a fix, I hop you don't mind.

@gpocentek gpocentek merged commit 31bca2f into master Jan 26, 2019
@max-wittig
Copy link
Member Author

@gpocentek Thank you!

@max-wittig max-wittig deleted the fix/wrong-rebase branch January 26, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpocentek gpocentek gpocentek approved these changes

Assignees

@gpocentek gpocentek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-wittig @gpocentek