From d74ff506ca0aadaba3221fc54cbebb678240564f Mon Sep 17 00:00:00 2001 From: Gauvain Pocentek Date: Sun, 3 Mar 2019 18:06:48 +0100 Subject: [PATCH] fix(api): Make *MemberManager.all() return a list of objects Fixes #699 --- RELEASE_NOTES.rst | 7 +++++++ gitlab/v4/objects.py | 6 ++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/RELEASE_NOTES.rst b/RELEASE_NOTES.rst index 44e457a87..4d9e392d1 100644 --- a/RELEASE_NOTES.rst +++ b/RELEASE_NOTES.rst @@ -4,6 +4,13 @@ Release notes This page describes important changes between python-gitlab releases. +Changes from 1.8 to 1.9 +======================= + +* ``ProjectMemberManager.all()`` and ``GroupMemberManager.all()`` now return a + list of ``ProjectMember`` and ``GroupMember`` objects respectively, instead + of a list of dicts. + Changes from 1.7 to 1.8 ======================= diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index 8348c76ca..c3f8a8154 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -740,7 +740,8 @@ def all(self, **kwargs): """ path = '%s/all' % self.path - return self.gitlab.http_list(path, **kwargs) + obj = self.gitlab.http_list(path, **kwargs) + return [self._obj_cls(self, item) for item in obj] class GroupMergeRequest(RESTObject): @@ -1955,7 +1956,8 @@ def all(self, **kwargs): """ path = '%s/all' % self.path - return self.gitlab.http_list(path, **kwargs) + obj = self.gitlab.http_list(path, **kwargs) + return [self._obj_cls(self, item) for item in obj] class ProjectNote(RESTObject):