Skip to content

Add new endpoint to get the variables of a pipeline #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2019
Merged

Add new endpoint to get the variables of a pipeline #785

merged 1 commit into from
Jun 10, 2019

Conversation

agustinhenze
Copy link

It adds a new endpoint which was released in the Gitlab CE 11.11.

@agustinhenze agustinhenze force-pushed the add-pipeline-get-variables-endpoint branch 2 times, most recently from 79a55f6 to 847ee7f Compare May 29, 2019 10:45
@gpocentek gpocentek self-requested a review June 8, 2019 07:28
gpocentek
gpocentek suggested changes Jun 8, 2019
View reviewed changes
Copy link
Contributor

@gpocentek gpocentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good, thanks!

We have more strict commit message checks now, could you update it to something like:

feat: add endpoint to get the variables of a pipeline

Thanks!

feat: add endpoint to get the variables of a pipeline
564de48 
It adds a new endpoint which was released in the Gitlab CE 11.11.

Signed-off-by: Agustin Henze <tin@redhat.com>
@agustinhenze agustinhenze force-pushed the add-pipeline-get-variables-endpoint branch from 847ee7f to 564de48 Compare June 10, 2019 11:05
@agustinhenze
Copy link
Author

Thanks for the review :). Done, commit message changed

@max-wittig max-wittig merged commit 463cedc into python-gitlab:master Jun 10, 2019
@gsemet
Copy link

gsemet commented Jun 17, 2019

Hi. Can you package a new version please? Thanks!

@max-wittig
Copy link
Member

Sure. We will do so. Soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpocentek gpocentek gpocentek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agustinhenze @gsemet @max-wittig @gpocentek