From 727f53619dba47f0ab770e4e06f1cb774e14f819 Mon Sep 17 00:00:00 2001 From: Mathieu Parent Date: Thu, 14 Nov 2019 10:37:18 +0100 Subject: [PATCH] fix(labels): ensure label.save() works Otherwise, we get: File "gitlabracadabra/mixins/labels.py", line 67, in _process_labels current_label.save() File "gitlab/exceptions.py", line 267, in wrapped_f return f(*args, **kwargs) File "gitlab/v4/objects.py", line 896, in save self._update_attrs(server_data) File "gitlab/base.py", line 131, in _update_attrs self.__dict__["_attrs"].update(new_attrs) TypeError: 'NoneType' object is not iterable Because server_data is None. --- gitlab/v4/objects.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index 24f623dcb..3ac7a4a9f 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -914,7 +914,7 @@ def update(self, name, new_data=None, **kwargs): new_data = new_data or {} if name: new_data["name"] = name - super().update(id=None, new_data=new_data, **kwargs) + return super().update(id=None, new_data=new_data, **kwargs) # Delete without ID. @exc.on_http_error(exc.GitlabDeleteError) @@ -3049,7 +3049,7 @@ def update(self, name, new_data=None, **kwargs): new_data = new_data or {} if name: new_data["name"] = name - super().update(id=None, new_data=new_data, **kwargs) + return super().update(id=None, new_data=new_data, **kwargs) # Delete without ID. @exc.on_http_error(exc.GitlabDeleteError)