Skip to content

README.rst: fix the upstream Docker image reference #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

vvv
Copy link
Contributor

@vvv vvv commented Nov 30, 2019

v1.8.0 is not available.

Unable to find image 'registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0' locally
docker: Error response from daemon: manifest for registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0 not found: manifest unknown: manifest unknown.

@max-wittig
Copy link
Member

Thanks for the MR. I would go for latest

@vvv
Copy link
Contributor Author

vvv commented Dec 1, 2019

I would go for latest

Done.

@max-wittig
Copy link
Member

@vvv Pipeline still fails, because the scope needs to be lowercase. Would you mind to adapt it to

docs(readme): fix docker image reference

Thanks 👍

@vvv
Copy link
Contributor Author

vvv commented Dec 2, 2019

We enforce commit messages to be formatted using the conventional-changelog. This leads to more readable messages that are easy to follow when looking through the project history.

This also keeps the barrier to entry for new contributors unnecessarily high.

password requirements

v1.8.0 is not available.
```
Unable to find image 'registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0' locally
docker: Error response from daemon: manifest for registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0 not found: manifest unknown: manifest unknown.
```
@max-wittig
Copy link
Member

But makes changelog generation easier ;) and you did it :D

@max-wittig max-wittig merged commit f6f5178 into python-gitlab:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants