Skip to content

[pyos][checklist] Add link to comparison with pygraphblas in README #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sneakers-the-rat opened this issue Apr 17, 2023 · 3 comments · Fixed by #439
Closed

[pyos][checklist] Add link to comparison with pygraphblas in README #438

sneakers-the-rat opened this issue Apr 17, 2023 · 3 comments · Fixed by #439
Labels
documentation Improve or add to documentation

Comments

@sneakers-the-rat
Copy link

The review checklist asks me to affirm there is a comparison to similar packages in the ecosystem in the README. I think that could be as simple as linking to https://python-graphblas.readthedocs.io/en/stable/getting_started/faq.html#what-is-the-relationship-between-python-graphblas-and-pygraphblas

Close this if you have already done that, I just looked and didn't see it, but i just scanned really briefly.

Part of: pyOpenSci/software-submission#81
@sneakers-the-rat sneakers-the-rat mentioned this issue Apr 17, 2023
Closed
24 tasks
@eriknw eriknw mentioned this issue Apr 18, 2023
Merged
@eriknw eriknw added the documentation Improve or add to documentation label Apr 18, 2023
@eriknw
Copy link
Member

eriknw commented Apr 18, 2023

I added a link to the FAQ to the README, which I think should be sufficient and I would argue is more useful (especially as we get more questions 😉 ) than using valuable space (and attention) to discuss a defunct package.

@eriknw
Copy link
Member

eriknw commented Apr 18, 2023

Regarding "comparing to similar packages in the ecosystem", I think it would actually be informative to compare to e.g. scipy.sparse, networkx, and igraph. I think such a comparison could go in the README and/or documentation.

SultanOrazbayev added a commit to SultanOrazbayev/python-graphblas that referenced this issue Apr 19, 2023
@SultanOrazbayev
Update README.md
a3e60c6 
Follows up on python-graphblas#438:

>Regarding "comparing to similar packages in the ecosystem", I think it would actually be informative to compare to e.g. scipy.sparse, networkx, and igraph. I think such a comparison could go in the README and/or documentation.
@SultanOrazbayev SultanOrazbayev mentioned this issue Apr 19, 2023
Merged
@sneakers-the-rat
Copy link
Author

Good with both of those :)

jim22k pushed a commit that referenced this issue Jul 5, 2023
@SultanOrazbayev @eriknw
Update README.md (#442)
e3118da 
* Update README.md

Follows up on #438:

>Regarding "comparing to similar packages in the ecosystem", I think it would actually be informative to compare to e.g. scipy.sparse, networkx, and igraph. I think such a comparison could go in the README and/or documentation.

* Update README.md

* Update README.md

Co-authored-by: Erik Welch <erik.n.welch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improve or add to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add link to FAQ to README eriknw/grblas
2 participants
@eriknw @sneakers-the-rat