Fix path to logo in docs (include _static in path)
#400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update and pin pydata-sphinx-theme to 0.13.1 - Remove circle around light/dark theme change icon - Remove "Show Source" button
|
Looks great, thanks @jim22k! I'm curious how you came up with these updates to the CSS--maybe you can show us sometime. Merging 🎉 |
|
It's odd, but now the dark version is not rendering correctly for me. I tried Safari and Chrome, clearing cache, but it shows now just like in the linked comment (so no logo and white text blocks in dark mode). |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logo just disappeared in the docs. Adding
_static/to the path seems to fix it. Ishtml_static_pathsupposed to do this for us?Reported here: #396 (comment)
Maybe we should pin to a specific version of
pydata-sphinx-theme.