From bf65519b74a8f6a6e2f2505fb4f2e628321ec784 Mon Sep 17 00:00:00 2001 From: Transurgeon Date: Wed, 9 Aug 2023 13:59:06 -0400 Subject: [PATCH] dropping support for python3.8 according to wiki --- .github/workflows/debug.yml | 2 +- .github/workflows/imports.yml | 4 +--- .github/workflows/publish_pypi.yml | 2 +- .github/workflows/test_and_build.yml | 10 +--------- .pre-commit-config.yaml | 2 +- pyproject.toml | 9 ++++----- scripts/check_versions.sh | 2 +- 7 files changed, 10 insertions(+), 21 deletions(-) diff --git a/.github/workflows/debug.yml b/.github/workflows/debug.yml index 794746f77..389905db5 100644 --- a/.github/workflows/debug.yml +++ b/.github/workflows/debug.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - pyver: [3.8] + pyver: [3.9] testopts: - "--blocking" # - "--non-blocking --record --runslow" diff --git a/.github/workflows/imports.yml b/.github/workflows/imports.yml index 18e6f637c..de9a7361d 100644 --- a/.github/workflows/imports.yml +++ b/.github/workflows/imports.yml @@ -30,7 +30,6 @@ jobs: id: pyver with: contents: | - 3.8 3.9 3.10 3.11 @@ -38,14 +37,13 @@ jobs: 1 1 1 - 1 test_imports: needs: rngs runs-on: ${{ needs.rngs.outputs.os }} # runs-on: ${{ matrix.os }} # strategy: # matrix: - # python-version: ["3.8", "3.9", "3.10", "3.11"] + # python-version: ["3.9", "3.10", "3.11"] # os: ["ubuntu-latest", "macos-latest", "windows-latest"] steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/publish_pypi.yml b/.github/workflows/publish_pypi.yml index cbe403724..abf3057ac 100644 --- a/.github/workflows/publish_pypi.yml +++ b/.github/workflows/publish_pypi.yml @@ -20,7 +20,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v4 with: - python-version: "3.8" + python-version: "3.9" - name: Install build dependencies run: | python -m pip install --upgrade pip diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index 4c1c0e312..cc2eb27b6 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -107,10 +107,8 @@ jobs: with: # We should support major Python versions for at least 36-42 months # We may be able to support pypy if anybody asks for it - # 3.8.16 0_73_pypy # 3.9.16 0_73_pypy contents: | - 3.8 3.9 3.10 3.11 @@ -118,7 +116,6 @@ jobs: 1 1 1 - 1 - name: RNG for source of python-suitesparse-graphblas uses: ddradar/choose-random-action@v2.0.2 id: sourcetype @@ -171,12 +168,7 @@ jobs: yamlver=$(python -c 'import random ; print(random.choice(["=5.4", "=6.0", ""]))') sparsever=$(python -c 'import random ; print(random.choice(["=0.13", "=0.14", ""]))') fmmver=$(python -c 'import random ; print(random.choice(["=1.4", "=1.5", "=1.6", "=1.7", ""]))') - if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.8') }} == true ]]; then - npver=$(python -c 'import random ; print(random.choice(["=1.21", "=1.22", "=1.23", "=1.24", ""]))') - spver=$(python -c 'import random ; print(random.choice(["=1.8", "=1.9", "=1.10", ""]))') - pdver=$(python -c 'import random ; print(random.choice(["=1.2", "=1.3", "=1.4", "=1.5", "=2.0", ""]))') - akver=$(python -c 'import random ; print(random.choice(["=1.9", "=1.10", "=2.0", "=2.1", "=2.2", "=2.3", ""]))') - elif [[ ${{ startsWith(steps.pyver.outputs.selected, '3.9') }} == true ]]; then + if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.9') }} == true ]]; then npver=$(python -c 'import random ; print(random.choice(["=1.21", "=1.22", "=1.23", "=1.24", "=1.25", ""]))') spver=$(python -c 'import random ; print(random.choice(["=1.8", "=1.9", "=1.10", "=1.11", ""]))') pdver=$(python -c 'import random ; print(random.choice(["=1.2", "=1.3", "=1.4", "=1.5", "=2.0", ""]))') diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index fef625a70..5fffc6f8f 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -54,7 +54,7 @@ repos: rev: v3.9.0 hooks: - id: pyupgrade - args: [--py38-plus] + args: [--py39-plus] - repo: https://github.com/MarcoGorelli/auto-walrus rev: v0.2.2 hooks: diff --git a/pyproject.toml b/pyproject.toml index fdd3a7a94..499faa2c3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -10,7 +10,7 @@ name = "python-graphblas" dynamic = ["version"] description = "Python library for GraphBLAS: high-performance sparse linear algebra for scalable graph analytics" readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" license = {file = "LICENSE"} authors = [ {name = "Erik Welch", email = "erik.n.welch@gmail.com"}, @@ -44,7 +44,6 @@ classifiers = [ "Operating System :: Microsoft :: Windows", "Programming Language :: Python", "Programming Language :: Python :: 3", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", @@ -157,7 +156,7 @@ dirty_template = "{tag}+{ccount}.g{sha}.dirty" [tool.black] line-length = 100 -target-version = ["py38", "py39", "py310", "py311"] +target-version = ["py39", "py310", "py311"] [tool.isort] sections = ["FUTURE", "STDLIB", "THIRDPARTY", "FIRSTPARTY", "LOCALFOLDER"] @@ -235,7 +234,7 @@ ignore-words-list = "coo,ba" [tool.ruff] # https://github.com/charliermarsh/ruff/ line-length = 100 -target-version = "py38" +target-version = "py39" select = [ # Have we enabled too many checks that they'll become a nuisance? We'll see... "F", # pyflakes @@ -396,7 +395,7 @@ convention = "numpy" [tool.pylint.messages_control] # To run a single check, do: pylint graphblas --disable E,W,R,C,I --enable assignment-from-no-return max-line-length = 100 -py-version = "3.8" +py-version = "3.9" enable = ["I"] disable = [ # Error diff --git a/scripts/check_versions.sh b/scripts/check_versions.sh index ffa440c22..f849c1329 100755 --- a/scripts/check_versions.sh +++ b/scripts/check_versions.sh @@ -14,4 +14,4 @@ conda search 'numba[channel=conda-forge]>=0.57.1' conda search 'pyyaml[channel=conda-forge]>=6.0' conda search 'flake8-bugbear[channel=conda-forge]>=23.7.10' conda search 'flake8-simplify[channel=conda-forge]>=0.20.0' -# conda search 'python[channel=conda-forge]>=3.8 *pypy*' +# conda search 'python[channel=conda-forge]>=3.9 *pypy*'