Skip to content

Add support for Python 3.12 #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 11, 2023
Merged

Add support for Python 3.12 #508

merged 12 commits into from
Oct 11, 2023

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 8, 2023

Also, test against python-suitesparse-graphblas 8.2.0.1

I followed the instructions: https://github.com/python-graphblas/python-graphblas/wiki/Support-new-Python-version

@eriknw
Copy link
Member Author

eriknw commented Oct 8, 2023

I think this is very close, but for sanity, I'd like to wait until matplotlib has been released and built for Python 3.12.

@galaxy001
Copy link

matplotlib support python 3.12 now.
https://pypi.org/project/matplotlib/3.8.0/

@eriknw
Copy link
Member Author

eriknw commented Oct 11, 2023

Thanks @galaxy001, right you are--good timing! Plus, Python 3.12 support just arrived this morning for matplotlib on conda-forge.

Now we just need to wait for tests to pass :)

Another things this PR portends is that we will likely stop using coveralls.io soon and rely only on codecov.io for coverage services. coveralls does not appear to be well-maintained for Python, and it restricts our version of coverage, which may be causing other headaches.

@coveralls
Copy link

coveralls commented Oct 11, 2023

Coverage Status

coverage: 99.725% (+0.01%) from 99.715% when pulling 22aa0df on eriknw:py312 into 43deb66 on python-graphblas:main.

@eriknw eriknw merged commit 39d52b1 into python-graphblas:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants