Add docstrings for using SS JIT, and make better #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - allow a SS JIT function to be registered under the same name with different input types - be extra-strict about input types for SS JIT - test numba JIT with select with udt
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
==========================================
+ Coverage 92.86% 99.58% +6.71%
==========================================
Files 95 95
Lines 21106 21253 +147
Branches 3950 3987 +37
==========================================
+ Hits 19600 21164 +1564
+ Misses 1342 65 -1277
+ Partials 164 24 -140 |
|
Thanks for taking a look @michelp! So I added codecov github comment in this PR. I don't know if I like it, but it's convenient to have an easy link to the coverage report. I made the message not quite as ugly as the default. Anyway, merging! I'll get overall approval from others before I do a release, which is coming soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
CC @michelp in case you want to look at the docstrings and signatures of our functions for using SuiteSparse:GraphBLAS JIT such as
gb.binary.ss.register_new--I think you're the most likely to show off something cool using the JIT ;)(also, let me know if you want help using the JIT locally).
I think we should cut a new release after this is merged.