Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

END_STREAM not marked when last chunk of length MAX_CHUNK #355

Open
PrimozGodec opened this issue Oct 26, 2017 · 0 comments
Open

END_STREAM not marked when last chunk of length MAX_CHUNK #355

PrimozGodec opened this issue Oct 26, 2017 · 0 comments

Comments

@PrimozGodec
Copy link
Contributor

https://github.com/Lukasa/hyper/blob/13e2a909e14349d14ae2b86217062e1568242b9a/hyper/http20/stream.py#L330

End of the stream is not marked when the last chunk is of size equal to MAX_CHUNK (1024). Condition len(data) < MAX_CHUNK works fine in all cases when the last chunk is of size smaller than 1024 but not in case when last chunk is of size 1024. If we change this to len(data) <= MAX_CHUNK it wont work since we will mark END_STREAM for every chunk. Suggested solution is to make another argument that tell you when you have a last chunk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant