Skip to content

Individual errors cause failing the whole query #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rytilahti opened this issue Jan 4, 2024 · 1 comment
Closed

Individual errors cause failing the whole query #616

rytilahti opened this issue Jan 4, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
0.7.0

Comments

@rytilahti
Copy link
Member

rytilahti commented Jan 4, 2024 •
edited
Loading

While provisioning a L900 I noticed that if the device time is off, trying to do anything on the device will fail with Got error: SmartDeviceException('Error querying device: 192.168.0.1: TIME_ERROR(-1601) for method: get_device_usage')

@sdb9696 maybe multiRequests should not completely fail if only some of the subrequests are reporting errors?

Failing queries on an unprovisioned P110:

  • TIME_ERROR(-1601) for method: get_device_usage
  • JSON_DECODE_FAIL_ERROR(-1003) for method: get_energy_usage
@rytilahti rytilahti added the bug Something isn't working label Jan 4, 2024
@rytilahti rytilahti added this to the 0.6.0 milestone Jan 11, 2024
@rytilahti rytilahti mentioned this issue Jan 11, 2024
Merged
@rytilahti rytilahti removed this from the 0.6.0 milestone Jan 11, 2024
@sdb9696 sdb9696 added this to the 0.7.0 milestone Feb 22, 2024
@sdb9696
Copy link
Collaborator

sdb9696 commented Feb 22, 2024

Fixed with #754

@sdb9696 sdb9696 closed this as completed Feb 22, 2024
@roblatour roblatour mentioned this issue Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@rytilahti @sdb9696