Add better timestamp support to cleanrecords module #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdb9696
commented
Jan 17, 2025
Comment on lines
-51
to
-59
| def deserialize(self, value: list[int]) -> Record: | ||
| """Deserialize list of maps into a dict.""" | ||
| data = { | ||
| "timestamp": value[0], | ||
| "clean_time": value[1], | ||
| "clean_area": value[2], | ||
| "dust_collection": value[3], | ||
| } | ||
| return Record.from_dict(data) |
There was a problem hiding this comment.
This doesn't work with the timezone dialect so moved this logic to __pre_deserialize__.
rytilahti
reviewed
Jan 17, 2025
Comment on lines
+451
to
+454
| # We move time to the beginning so other modules can access the | ||
| # time and timezone after update if required. e.g. cleanrecords | ||
| if Time.__name__ in self._modules: | ||
| self._modules.move_to_end(Time.__name__, last=False) |
There was a problem hiding this comment.
Tbh, this feels rather icky and I would rather like to avoid it, but I suppose it is what it is :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.