Skip to content

Possible performance regression with LDAPBytesWarning #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tiran opened this issue Dec 15, 2017 · 1 comment
Closed

Possible performance regression with LDAPBytesWarning #133

tiran opened this issue Dec 15, 2017 · 1 comment
Labels
performance

Comments

@tiran
Copy link
Member

tiran commented Dec 15, 2017

From #128 (comment)

I suspect (without profiling) that warnings are a performance regression for add* and search*. All add op take a modlist, all search ops take an optional attrlist. The lists can be pretty long and we do the full warning dance for every entry. We should only warn once per operation.
@tiran tiran mentioned this issue Jan 12, 2018
Closed
@encukou
Copy link
Member

encukou commented Sep 20, 2019

If warnings cause performance issues, fix your code to avoid the warnings. Or choose silent rather than warn in production.

Also, this is only relevant for Python 2, which has less than 3 months of support left.
I'll go ahead and close it now.

@encukou encukou closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@encukou @tiran