Merge pull request #236 from p1c2u/fix/case-insensitive-headers-fix

p1c2u · web-flow · commit 2680b62ce721 · 2020-04-11T13:09:07.000+01:00
Case insensitive headers fix
diff --git a/openapi_core/contrib/django/requests.py b/openapi_core/contrib/django/requests.py
@@ -39,7 +39,7 @@ def create(cls, request):
         parameters = RequestParameters(
             path=path,
             query=request.GET,
-            header=request.headers,
+            header=request.headers.items(),
             cookie=request.COOKIES,
         )
         full_url_pattern = urljoin(
diff --git a/openapi_core/validation/request/datatypes.py b/openapi_core/validation/request/datatypes.py
@@ -1,6 +1,6 @@
 """OpenAPI core validation request datatypes module"""
 import attr
-from werkzeug.datastructures import ImmutableMultiDict
+from werkzeug.datastructures import ImmutableMultiDict, Headers
 
 from openapi_core.validation.datatypes import BaseValidationResult
 
@@ -13,14 +13,14 @@ class RequestParameters(object):
         query
             Query string parameters as MultiDict. Must support getlist method.
         header
-            Request headers as dict.
+            Request headers as Headers.
         cookie
             Request cookies as dict.
         path
             Path parameters as dict. Gets resolved against spec if empty.
     """
     query = attr.ib(factory=ImmutableMultiDict)
-    header = attr.ib(factory=dict)
+    header = attr.ib(factory=Headers, converter=Headers)
     cookie = attr.ib(factory=dict)
     path = attr.ib(factory=dict)
 
diff --git a/tests/unit/security/test_providers.py b/tests/unit/security/test_providers.py
@@ -15,13 +15,17 @@ def scheme(self):
     def provider(self, scheme):
         return HttpProvider(scheme)
 
-    def test_issue29427(self, provider):
+    @pytest.mark.parametrize(
+        'header',
+        ['authorization', 'Authorization', 'AUTHORIZATION'],
+    )
+    def test_header(self, provider, header):
         """Tests HttpProvider against Issue29427
         https://bugs.python.org/issue29427
         """
         jwt = 'MQ'
         headers = {
-            'Authorization': 'Bearer {0}'.format(jwt),
+            header: 'Bearer {0}'.format(jwt),
         }
         request = MockRequest(
             'http://localhost', 'GET', '/pets',

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def create(cls, request):`
`39`	`39`	`parameters = RequestParameters(`
`40`	`40`	`path=path,`
`41`	`41`	`query=request.GET,`
`42`		`- header=request.headers,`
	`42`	`+ header=request.headers.items(),`
`43`	`43`	`cookie=request.COOKIES,`
`44`	`44`	`)`
`45`	`45`	`full_url_pattern = urljoin(`