Small change to Schema model to allow generated specs to be picklable

Beirdo · Beirdo · commit 7993de894ed9 · 2020-04-19T13:08:07.000-07:00
- overriding __dict__ is death for pickling.   I renamed it to __newdict__
  and tweaked the one user of it, and now this part of the structure is
  working fine for pickling
- there are also upstream changes in jsonschema that need to be in for the
  overall success
- this allows me to create the API spec from a swagger file once (which takes
  2-20s for the files I'm working with), and cache the result as a pickle file
  for loading on the next startup (assuming the swagger file hasn't been
  updated).  The load from pickle files takes 2-5ms.  This is an improvement
  of load time by 3 orders of magnitude.
diff --git a/openapi_core/schema/schemas/models.py b/openapi_core/schema/schemas/models.py
@@ -67,8 +67,12 @@ def __init__(
 
         self._source = _source
 
+    # Overriding object.__dict__ is a VERY bad idea as it totally breaks any
+    # possibility of pickling this object.  Pickling marshalls via object.__dict__
+    # via default __getstate__ and __setstate__ methods.  This is now renamed to
+    # keep the functionality for the validators, but keep pickling operational.
     @property
-    def __dict__(self):
+    def __newdict__(self):
         return self._source or self.to_dict()
 
     def to_dict(self):
diff --git a/openapi_core/unmarshalling/schemas/factories.py b/openapi_core/unmarshalling/schemas/factories.py
@@ -86,7 +86,7 @@ def get_validator(self, schema):
         }
         if self.context is not None:
             kwargs[self.CONTEXT_VALIDATION[self.context]] = True
-        return OAS30Validator(schema.__dict__, **kwargs)
+        return OAS30Validator(schema.__newdict__, **kwargs)
 
     def _get_format_checker(self):
         fc = deepcopy(oas30_format_checker)

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ def get_validator(self, schema):`
`86`	`86`	`}`
`87`	`87`	`if self.context is not None:`
`88`	`88`	`kwargs[self.CONTEXT_VALIDATION[self.context]] = True`
`89`		`- return OAS30Validator(schema.__dict__, **kwargs)`
	`89`	`+ return OAS30Validator(schema.__newdict__, **kwargs)`
`90`	`90`
`91`	`91`	`def _get_format_checker(self):`
`92`	`92`	`fc = deepcopy(oas30_format_checker)`