Enable mypy

p1c2u · p1c2u · commit 80399aa72ac7 · 2021-08-16T22:27:53.000+01:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -15,6 +15,13 @@ repos:
       - id: pyupgrade
         args: ["--py36-plus"]
 
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v0.910
+    hooks:
+      - id: mypy
+        args: []
+        additional_dependencies: [types-requests==2.25.6]
+
   - repo: local
     hooks:
       - id: flynt
diff --git a/openapi_core/templating/datatypes.py b/openapi_core/templating/datatypes.py
@@ -1,12 +1,12 @@
 from dataclasses import dataclass
+from dataclasses import field
 from typing import Dict
-from typing import Optional
 
 
 @dataclass
 class TemplateResult:
-    pattern: Optional[str] = None
-    variables: Optional[Dict] = None
+    pattern: str
+    variables: Dict = field(default_factory=dict)
 
     @property
     def resolved(self):
diff --git a/openapi_core/templating/paths/finders.py b/openapi_core/templating/paths/finders.py
@@ -50,7 +50,7 @@ def _get_paths_iter(self, full_url_pattern):
             # simple path.
             # Return right away since it is always the most concrete
             if full_url_pattern.endswith(path_pattern):
-                path_result = TemplateResult(path_pattern, {})
+                path_result = TemplateResult(path_pattern)
                 yield (path, path_result)
             # template path
             else:
@@ -93,7 +93,7 @@ def _get_servers_iter(self, full_url_pattern, ooperations_iter):
                     server_url = server_url[:-1]
                 # simple path
                 if server_url_pattern == server_url:
-                    server_result = TemplateResult(server["url"], {})
+                    server_result = TemplateResult(server["url"])
                     yield (
                         path,
                         operation,
diff --git a/openapi_core/testing/factories.py b/openapi_core/testing/factories.py
@@ -1,6 +1,9 @@
+from typing import Dict
+
+
 class FactoryClassMock:
 
-    _instances = {}
+    _instances: Dict[object, object] = {}
 
     def __new__(cls, obj):
         if obj not in cls._instances:
diff --git a/openapi_core/unmarshalling/schemas/unmarshallers.py b/openapi_core/unmarshalling/schemas/unmarshallers.py
@@ -1,5 +1,7 @@
 import logging
 from functools import partial
+from typing import Dict
+from typing import Optional
 
 from isodate.isodatetime import parse_datetime
 from openapi_schema_validator._format import oas30_format_checker
@@ -32,7 +34,7 @@
 
 class BaseSchemaUnmarshaller:
 
-    FORMATTERS = {
+    FORMATTERS: Dict[Optional[str], Formatter] = {
         None: Formatter(),
     }
 
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -9,6 +9,21 @@ source =["openapi_core"]
 [tool.coverage.xml]
 output = "reports/coverage.xml"
 
+[tool.mypy]
+files = "openapi_core"
+
+[[tool.mypy.overrides]]
+module = [
+    "django.*",
+    "falcon.*",
+    "isodate.*",
+    "more_itertools.*",
+    "openapi_spec_validator.*",
+    "openapi_schema_validator.*",
+    "werkzeug.*",
+]
+ignore_missing_imports = true
+
 [tool.poetry]
 name = "openapi-core"
 version = "0.14.2"
@@ -69,6 +84,8 @@ sphinx = "^4.0.2"
 sphinx-rtd-theme = "^0.5.2"
 strict-rfc3339 = "^0.7"
 webob = "*"
+mypy = "^0.910"
+types-requests = "^2.25.6"
 
 [tool.pytest.ini_options]
 addopts = """
