Handle parameter deserialization errors

p1c2u · p1c2u · commit b75798aa6215 · 2018-08-17T13:25:31.000+01:00
diff --git a/openapi_core/schema/parameters/models.py b/openapi_core/schema/parameters/models.py
@@ -108,7 +108,10 @@ def unmarshal(self, value):
         if not self.schema:
             return value
 
-        deserialized = self.deserialize(value)
+        try:
+            deserialized = self.deserialize(value)
+        except (ValueError, AttributeError) as exc:
+            raise InvalidParameterValue(str(exc))
 
         try:
             return self.schema.unmarshal(deserialized)
diff --git a/tests/integration/test_petstore.py b/tests/integration/test_petstore.py
@@ -297,6 +297,26 @@ def test_get_pets_tags_param(self, spec, response_validator):
         assert response_result.errors == []
         assert response_result.data == data_json
 
+    def test_get_pets_parameter_deserialization_error(self, spec):
+        host_url = 'http://petstore.swagger.io/v1'
+        path_pattern = '/v1/pets'
+        query_params = {
+            'limit': 1,
+            'tags': 12,
+        }
+
+        request = MockRequest(
+            host_url, 'GET', '/pets',
+            path_pattern=path_pattern, args=query_params,
+        )
+
+        with pytest.raises(InvalidParameterValue):
+            request.get_parameters(spec)
+
+        body = request.get_body(spec)
+
+        assert body is None
+
     def test_get_pets_wrong_parameter_type(self, spec):
         host_url = 'http://petstore.swagger.io/v1'
         path_pattern = '/v1/pets'
