tabs: add TabStop.leader setter

DKWoods · Steve Canny · commit 018cb8c5f51a · 2016-05-06T17:56:34.000-07:00
diff --git a/docx/text/tabstops.py b/docx/text/tabstops.py
@@ -72,10 +72,15 @@ def alignment(self, value):
     def leader(self):
         """
         A member of :ref:`WdTabLeader` specifying a repeating character used
-        as a "leader", filling in the space spanned by this tab.
+        as a "leader", filling in the space spanned by this tab. Assigning
+        |None| produces the same result as assigning `WD_TAB_LEADER.SPACES`.
         """
         return self._element.leader
 
+    @leader.setter
+    def leader(self, value):
+        self._element.leader = value
+
     @property
     def position(self):
         """
diff --git a/features/tab-tabstop-props.feature b/features/tab-tabstop-props.feature
@@ -56,7 +56,6 @@ Feature: Tab stop properties
       | a dotted     | DOTS   |
 
 
-  @wip
   Scenario Outline: Set tab stop leader
    Given a tab stop having <leader> leader
     When I assign <member> to tab_stop.leader
diff --git a/tests/text/test_tabstops.py b/tests/text/test_tabstops.py
@@ -39,10 +39,15 @@ def it_can_change_its_alignment(self, alignment_set_fixture):
         tab_stop.alignment = value
         assert tab_stop._element.xml == expected_xml
 
-    def it_knows_its_leader(self, leader_fixture):
-        tab_stop, expected_value = leader_fixture
+    def it_knows_its_leader(self, leader_get_fixture):
+        tab_stop, expected_value = leader_get_fixture
         assert tab_stop.leader == expected_value
 
+    def it_can_change_its_leader(self, leader_set_fixture):
+        tab_stop, value, expected_xml = leader_set_fixture
+        tab_stop.leader = value
+        assert tab_stop._element.xml == expected_xml
+
     # fixture --------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -71,12 +76,29 @@ def alignment_set_fixture(self, request):
         ('w:tab{w:leader=none}', 'SPACES'),
         ('w:tab{w:leader=dot}',  'DOTS'),
     ])
-    def leader_fixture(self, request):
+    def leader_get_fixture(self, request):
         tab_stop_cxml, member = request.param
         tab_stop = TabStop(element(tab_stop_cxml))
         expected_value = getattr(WD_TAB_LEADER, member)
         return tab_stop, expected_value
 
+    @pytest.fixture(params=[
+        ('w:tab',                  'DOTS',   'w:tab{w:leader=dot}'),
+        ('w:tab{w:leader=dot}',    'DASHES', 'w:tab{w:leader=hyphen}'),
+        ('w:tab{w:leader=hyphen}', 'SPACES', 'w:tab'),
+        ('w:tab{w:leader=hyphen}', None,     'w:tab'),
+        ('w:tab',                  'SPACES', 'w:tab'),
+        ('w:tab',                  None,     'w:tab'),
+    ])
+    def leader_set_fixture(self, request):
+        tab_stop_cxml, new_value, expected_cxml = request.param
+        tab_stop = TabStop(element(tab_stop_cxml))
+        value = (
+            None if new_value is None else getattr(WD_TAB_LEADER, new_value)
+        )
+        expected_xml = xml(expected_cxml)
+        return tab_stop, value, expected_xml
+
     @pytest.fixture
     def position_get_fixture(self, request):
         tab_stop = TabStop(element('w:tab{w:pos=720}'))
