-
Notifications
You must be signed in to change notification settings - Fork 255
docs: improve documentation organization and clarity #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@wyardley, would you mind doing a documentation review on the website related to configuration and changelog templates pages? I've done significant updates to both with the last two releases and I'm wondering if I missed something or if its clear about the new (& old) functionality. I'm about to do more documentation changes and it would be good to incorporate that feedback in at that time. If you want to add your findings here that would be great. Thanks! |
I took a quick look through. Overall, I didn't see anything that stuck out too much. I'm not using this project super actively currently, but hopefully people will create issues or PRs if they do come up with things that are hard to understand. With Jinja, my high level take is that maybe more presets builtin (or in That said, for me, it's probably a matter of style / personal preference, but I think the code examples in this section might be more readable if they were written somewhat like this: {%- if ctx.changelog_mode == "init" -%}
{%- include ".changelog_init.md.j2" -%}
{%- elif ctx.changelog_mode == "update" -%}
{%- include ".changelog_update.md.j2" -%}
{%- endif -%} (the dashes to suppress newlines might need to be adjusted slightly -- this is just pseudo-code). vs how they are now: {% if ctx.changelog_mode == "init"
%}{% include ".changelog_init.md.j2"
%}{#
#}{% elif ctx.changelog_mode == "update"
%}{% include ".changelog_update.md.j2"
%}{#
#}{% endif
%} I took a quick look through the docs top level, and here are a few things that kind of stuck out (a couple of them may not directly be related to configuration or changelog templates):
|
I appreciate you taking the time to help. Thank you for the feedback!
That is likely a good point. I have considered a section on the documentation for templates that are from the community that could be added via PR. Unfortunately, It doesn't seem to be a way to do built in macros but I have been adding custom filters to handle common tasks. The newer default templates are using some macros so those will be a starting point. Jinja itself is just complicated syntactically and unfortunately to write out these good templates seems to be just as complex. I would hope to have the default template good for most people and then the customization that is done isn't that much but a copy and modify from the default. I like the feature idea about pulling from a common template off of git. That would be great for maintainability for sure. Thanks! Agree to disagree on the jinja styling format. If only the syntax coloring didn't go away with multi-line segements but oh well. This format has been the one that has been the most readable with more complex templates I'm writing now and after the significant whitespace validation, I've been pulling my hair out over with testing, this style format does not leave any whitespace to chance (the
It was on purpose but will can reconsider.
Good catch, I don't know how that happened.
Yeah that looks awful, I'm sure that wasn't the desired result. Will add it to my list.
Yes, it is a line item of |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in work |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Documentation Error
There are a few sections that seem out of place at the top level. Revamp the site for longer term maintainence and add a concepts and best practices page for people to consider.
The text was updated successfully, but these errors were encountered: