-
Notifications
You must be signed in to change notification settings - Fork 255
Precommit command is run before versioned files are edited #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
While I still believe this to be a bug, this could also be a feature request to add BitBucket server and cloud to the HVCS options. I haven't had any time to look through the code, so I don't know if the bug is easier than the feature. |
This issue is stale because it has not been confirmed or planned by the maintainers and has been open 90 days with no recent activity. It will be closed in 7 days, if no further activity occurs. Thank you for your contributions. |
Still an issue/feature-request. |
@chet-manley, first, thank you for being one of the few people to respond to the stale activity just added! Secondly, as of Also, we do not support a pre commit command any more relating to publish. Likely you will need to switch to use the Let me know if PSR now fits your needs. |
Finally had the time to look into this, and I've gotta say, the 7 -> 8 changes are significant. I believe I have overcome most hurdles, but am stuck on two significant showstoppers.
All-in-all, I think the provided 7 -> 8 migration docs misses on some very key differences between the versions, unless I completely missed something obvious. |
Yes, the changelog command and version command run a full changelog regeneration (this has its problems, see #858, #722). I will need to know what was incorrect (expected vs. actual) about your paths to the commits. Since you have set the type to
Yes, that is the current default as of
Yes, the old style changelog was not retained, see #737. I became the maintainer after
This could be many different things (branching strategy, merging strategy, commit syntax). I usually request the log generated via |
This issue has not received a response in 14 days. If no response is received in 7 days, it will be closed. We look forward to hearing from you. |
This issue was closed because no response was received. |
Looks like I didn't respond in time, work has been very busy. Probably fine to leave closed though, as my OP is two versions old and no longer relevant to the project. Hopefully I can use your suggestions to perform some more testing, although I must say it would be really nice if the default Changelog formatter matched the old style without having to write my own (I may end up waiting for #737). That should definitely be mentioned in the migrations docs for people stuck on v7, as it is probably the biggest breaking change and takes considerable work if you don't want to lose thousands of lines of formatted changes. |
@chet-manley, I have no problem opening the issue back up. Or just open a new issue related to your issues with v8 or 9. The docs can always be better, and I can see if I can add to that migration docs for the changelog topic. I also requested a git tree of your repo where you don't think the version was calculated properly. |
The problem
When running
publish
, the command defined inpre_commit_command
is run before versioned files are updated.Expected behavior
Precommit command expected to run directly before commit, after PSR has already edited files.
Additional context
Found this issue when trying to mitigate another issue (changelog commit links use github URLs). I need to run a sed command on the changelog before it is committed to replace GH URLs with appropriate BB URLs.
The text was updated successfully, but these errors were encountered: