-
Notifications
You must be signed in to change notification settings - Fork 255
Allow --no-tag to overwrite --commit #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's more of a historic thing that is not evaluated together. I added the
We already have the
Yes, creating a commit with the version identified is kinda silly if you don't end up tagging it. PSR no longer reads commit messages to determine versions, so it would identify the same version from the same set of tags regardless if the last commit was a version commit or not. To be clear though, To summarize the result:
which means:
After writing this, yes I don't think this will cause any problems to have one imply the other, however, I do believe this will be a breaking change when added. |
Hi @codejedi365, Now it is possible to do really almost anything. It is possible to only create a tag, to only create a commit and to push those independently. The biggest change is really just that we can now create a commit without a tag which can be helpful in some very niche circumstances. I did mark it with a breaking fix, as it changes the behavior of |
Looking to implement as part of the |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog as I haven't done much of the v10 breaking change items yet but getting close |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog but getting close to a v10 release so it will be published soon |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog |
Description
This is related to the command
semantic-release version
:I would like to run semantic-release without tags for this use case where another process creates a tag.
However as described in the documentation
--no-tag
doesn't apply to the--commit
step.Is there a reason that
--no-tag
only applies to the tagging step?Would it be possible for
--no-tag
to also apply to the--commit
step?Use cases
With the current setup running
--commit
makes--tag/--no-tag
useless as it will never create a tag different from the tag that is created by--commit
, is that right? If that's the case, then there shouldn't be anything in the way for us to set it up so that--no-tag
also applies to the tag created by--commit
.Possible implementation
I'd be happy of course to create a PR but wanted to check with what you all think.
The text was updated successfully, but these errors were encountered: