-
Notifications
You must be signed in to change notification settings - Fork 255
Feature request: Support git push options #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @mmomper, Thank you for submitting this feature request. I've been dwelling on what is the best course of action here. I can understand the need for PSR providing some level of triggering support for My hesitation with your recommended implementation is that we support more than one hosted version control system (HVCS) and my cursory look is that GitHub does not support push options but GitLab does. I have not looked into Gitea or BitBucket's compatibility yet but that could be different as well. This leads me to consider a configuration option that basically defines which type of Prior to reading up on push options, my recommendation would have been to use the
Can you expand upon the problem with this? When I work with GitLab CI, generally if I'm using a |
Hi @codejedi365 , Thanks for the reply and thoughts about it. First of all, my issue with the When the new commit is created and pushed, the CI gets skipped, as intended. But when the Tag is created and pushed, the CI for the Tag is also skipped, which may be unintended. I read somewhere that, if this commit is the lates of an MR, the CI for the merge would also be skipped (not my use case but I think it is something to not forget about). In my use case, I thought about triggering a CI run on Tags in which the package gets pushed to the JFrog we are using. I would agree, creating a switch/config option for every push option is not a good practice since the supported options are not specified by Git but by the HVCS implementation. I thought about a generic flag/config like Of course this could be archived with not including |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in the backlog, haven't gotten back around to the implementation |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog |
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue? |
Still in backlog |
Description
It would be nice to support git push options (added in Git 2.10.2). Preferable separated for the commit push and the tag push.
Use cases
We are using GitLab CI/CD and want to use this tool for version management but don't want a pipeline run for the version bump commit. This could be archived by using the push option ci.skip for the new commit.
Adding [skip ci] to every commit has also impact on everything else referencing this commit (for example the tag).
Possible implementation
I tested that it works by simply modifying the commit push line from
repo.git.push(remote_url, branch)
torepo.git.push(remote_url, branch, "-o", "ci.skip")
and it works.I did not create a PR because I'm unsure which is the best option for adding this as a cli/config parameter.
The text was updated successfully, but these errors were encountered: