Skip to content

__getitem__ returns None for version parts that are falsy #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tlaferriere opened this issue Jun 9, 2020 · 0 comments · Fixed by #261
Closed

__getitem__ returns None for version parts that are falsy #260

tlaferriere opened this issue Jun 9, 2020 · 0 comments · Fixed by #261
Labels
Bug Error, flaw or fault to produce incorrect or unexpected results

Comments

@tlaferriere
Copy link
Contributor

For example, VersionInfo(0, 1, 0, 'r.1')[2] returns None when it should return 0.
@tomschr tomschr added the Bug Error, flaw or fault to produce incorrect or unexpected results label Jun 9, 2020
@tomschr tomschr linked a pull request Jun 9, 2020 that will close this issue
Fix #260 __getitem__ returning None on falsy parts #261
Merged
tomschr added a commit that referenced this issue Jun 10, 2020
@tlaferriere @tomschr
Fix #260 __getitem__ returning None on falsy parts
f332326 
* Fix #260 and add tests for these special cases 
* Fix IndexError not being thrown every time it should
* Update CHANGELOG.rst

Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
@tomschr tomschr mentioned this issue Jun 15, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Error, flaw or fault to produce incorrect or unexpected results
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #260 __getitem__ returning None on falsy parts
2 participants
@tomschr @tlaferriere