Skip to content

Use UTC dates #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lonami opened this issue Mar 14, 2019 · 2 comments · Fixed by #1485
Closed

Use UTC dates #1362

Lonami opened this issue Mar 14, 2019 · 2 comments · Fixed by #1485

Comments

@Lonami
Copy link

Lonami commented Mar 14, 2019

python-telegram-bot/telegram/utils/helpers.py

Lines 78 to 90 in 4397903

def from_timestamp(unixtime):
"""
Args:
unixtime (int):
Returns:
datetime.datetime:
"""
if not unixtime:
return None
return datetime.fromtimestamp(unixtime)

Should probably be using tz=timezone.utc. Python's datetime isn't the best, and fromtimestamp by default sets no tz information, which uses the local time, which in turn is generally a bad idea.
@jsmnbom jsmnbom added ⚙️ bot-api affected functionality: bot-api bug 🐛 and removed ⚙️ bot-api affected functionality: bot-api labels Mar 14, 2019
@Eldinnie Telegram GithubBot Revised
Copy link
Member

@Lonami I guess we all agree it should be UTC, but it is a breaking change. Maybe we can get it in before official v12 release?

@PaulSonOfLars
Copy link
Contributor

I agree, since there's a breaking change spree for v12, might as well add this in

@Bibo-Joshi Bibo-Joshi mentioned this issue Aug 27, 2019
Merged
@n5y n5y mentioned this issue Dec 8, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use UTC in from_timestamp python-telegram-bot/python-telegram-bot
5 participants
@Eldinnie @jsmnbom @Lonami @PaulSonOfLars @Bibo-Joshi