Skip to content

order of the serialized dictionary in tests #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Feb 2, 2020 · 3 comments
Closed

order of the serialized dictionary in tests #1747

Bibo-Joshi opened this issue Feb 2, 2020 · 3 comments
Labels
⚙️ tests affected functionality: tests

Comments

@Bibo-Joshi
Copy link
Member

in py3.5 we don't have a guarantee on the order of the serialized dictionary to string
skip related tests on py3.5 (e.g. test_json_changes in test_persistence)
@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Feb 2, 2020
@Bibo-Joshi
Copy link
Member Author

Closed by #1748

@Bibo-Joshi
Copy link
Member Author

Seems like #1748 isn't actually working … See here

@Bibo-Joshi Bibo-Joshi reopened this Feb 3, 2020
@Bibo-Joshi
Copy link
Member Author

Closed by #1752

@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bibo-Joshi