Skip to content

Use tempfile module in tests #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Feb 8, 2020 · 2 comments · Fixed by #1808
Closed

Use tempfile module in tests #1765

Bibo-Joshi opened this issue Feb 8, 2020 · 2 comments · Fixed by #1808
Labels
⚙️ tests affected functionality: tests
Milestone
13.0

Comments

@Bibo-Joshi
Copy link
Member

E.g. in test_persistence, but also check the other tests. Better than actually writing to disk.
@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Feb 8, 2020
@Bibo-Joshi Bibo-Joshi added this to the 13.0 milestone Feb 8, 2020
@Bibo-Joshi Bibo-Joshi mentioned this issue Feb 21, 2020
Closed
8 tasks
@Bibo-Joshi
Copy link
Member Author

Mh, with tempfile module there is no way to specify the exact file name of the created temporary files. But PicklePersistence will look for specific file names and I wouldn't fancy monkey patching the load methods of PicklePersistence in the tests …

@tsnoam Telegram GithubBot Revised
Copy link
Member

tsnoam commented Feb 26, 2020

@Bibo-Joshi What about using tempfile to create a temp directory?

@Bibo-Joshi Bibo-Joshi mentioned this issue Mar 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
13.0
Development

Successfully merging a pull request may close this issue.

Use temporary directories in test_persistence python-telegram-bot/python-telegram-bot
2 participants
@tsnoam @Bibo-Joshi