Skip to content

Don't use builtin function names as variables #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Feb 8, 2020 · 2 comments · Fixed by #1792
Closed

Don't use builtin function names as variables #1766

Bibo-Joshi opened this issue Feb 8, 2020 · 2 comments · Fixed by #1792
Milestone
13.0

Comments

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Feb 8, 2020 •
edited
Loading

There is e.g. all in PicklePersistence and I think also type somewhere. Also id
@Bibo-Joshi Bibo-Joshi added this to the 13.0 milestone Feb 8, 2020
@tsnoam Telegram GithubBot Revised
Copy link
Member

tsnoam commented Feb 8, 2020

@Bibo-Joshi "type" might be forced upon us because of it is derived from telegram API.

@Poolitzer Telegram GithubBot Revised
Copy link
Member

@tsnoam Actually, I think most of our usage of built-in function names will be where we take the naming from the API, and I dont think its worth changing that. Nevertheless, I can have a look later and see if I find issues of that in other places

This was referenced Feb 21, 2020
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging a pull request may close this issue.

Remove builtin names where possible python-telegram-bot/python-telegram-bot
3 participants
@tsnoam @Bibo-Joshi @Poolitzer