-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[FEATURE] Extensions of Defaults #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
what the heck? ^^ |
Read as: Add default setting for making |
Possible candidates to add to the Defaults concept:
tzinfo
We should use Defauts.tzinfo as default instead of UTC … That would mean:
when
, usewhen.replace(tzinfo=defaults.tzinfo)
This would basically not change the current set up, but just put it under the hood
Message.date
and all the friends should also usedefaults.tzinfo
, so basically everydatetime
instance occuring in the lib.Arguments of Filters
How to make it work: We would need to override those attributes on
dispatcher.add_handler
somehow. that's pretty much the only time, the filters and the dispatcher can see each other …Dice.emoji
Dice
is positional and not optionalReplyKeyboardMarkup
resize_keyboard
one_time_keyboard
Redesign of
default_quote
Right now,
default_quote
get's passed from getting updates through all objects, whose attributes have aMessage
attribute and is set as attribute inMessage
. But as theMessage.reply_*
methods only work with a bot anyway, we could just accessMessage.bot.defaults.default_quote
.See #1965
The text was updated successfully, but these errors were encountered: