[BUG] Context manager not working with MessageQueue #2035
Comments
|
A solution specifically for new_args = []
for arg in self.args:
if InputFile.is_file(arg):
new_args.append(InputFile(arg))
else:
new_args.append(arg)
self.args = tuple(new_args)
for key, value in self.kwargs.items():
if InputFile.is_file(value):
self.kwargs[key] = InputFile(value)We would need to check, if we would need to handle more things like this, but at least atm I can't think of anything else … |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
Set up a bot with a MessageQueue as described in the wiki
Override methods send_document, send_photo with @messagequeue.queuedmessage decorator
Open file with
context managerand try to send itExpected behaviour
Files must be sent to chat as usual, like they do without MessageQueue
Actual behaviour
Files are not sent. As I found, file is closed at the moment it should have sent.
And we have:
ValueError: read of closed fileof course.Why this happens and how to overcome that (steal that topic)
Files are closed before actual send, because send_document returns Promise object instead of message, you know, because it's messagequeue. So that Promise results after context manager close this file.
HotFix: You should wait for promise.result() if you want to close file properly.
Or InputFile should close file after it is done with it, and you don't have to worry about it.
Hope I fill everything right.
The text was updated successfully, but these errors were encountered: