Skip to content

Make BP.flush an abstract method #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Dec 3, 2020 · 1 comment · Fixed by #2624
Closed

Make BP.flush an abstract method #2231

Bibo-Joshi opened this issue Dec 3, 2020 · 1 comment · Fixed by #2624
Labels
🛠 breaking change type: breaking
Milestone
v20.0a0

Comments

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Dec 3, 2020 •
edited
Loading

Don't know why we skipped that in #1905, but as BasePersistence is an interface, it makes sense for all methods to be abcs. As flush currently doesn't raise NotImplementedError, this is strictly speaking breaking, so putting this on the v14 milestone.
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Dec 3, 2020
@Bibo-Joshi Bibo-Joshi added the 🛠 breaking change type: breaking label Dec 3, 2020
@Bibo-Joshi Bibo-Joshi mentioned this issue May 14, 2021
Merged
3 tasks
@harshil21 harshil21 mentioned this issue Aug 9, 2021
Closed
@harshil21 harshil21 linked a pull request Aug 9, 2021 that will close this issue
make BP.flush() abstract #2620
Closed
@starry-shivam starry-shivam mentioned this issue Aug 10, 2021
Merged
2 tasks
@Bibo-Joshi
Copy link
Member Author

closed by #2624 (only merged into v14 now, so GH doesn't notice …)

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🛠 breaking change type: breaking
Projects
None yet
Milestone
v20.0a0
1 participant
@Bibo-Joshi