Skip to content

Refactor test_stars #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bibo-Joshi opened this issue Dec 5, 2024 · 0 comments · Fixed by #4615
Closed

Refactor test_stars #4593

Bibo-Joshi opened this issue Dec 5, 2024 · 0 comments · Fixed by #4615
Labels
⚙️ tests affected functionality: tests

Comments

@Bibo-Joshi
Copy link
Member

test_stars currently tries to avoid test duplication by abstracting a lot away in fixtures and parametrizing the tests. The intention behind this certainly was good!
Unfortunately, it leads to the tests being very convoluted, hard to navigate and it being easy to forget updating everything on changes.

I strongly suggest that we instead use the boilerplate approach. It's more manuel, sure, but GitHub Copilot will take care of most of that and the result will be that we now again what we're testing :D

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ tests affected functionality: tests
Projects
None yet
1 participant