Skip to content

fix defaults #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 19, 2021
Merged

fix defaults #2363

merged 24 commits into from
Feb 19, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Feb 5, 2021

Closes #2361

Changes the cryptography requirement to !=3.4 as that release contains a bug with cyclical imports, see pyca/cryptography#5758 .

On the fly:

  • re-adds docs for get_updates.read_latency, which apparently got lost somewhere around 2017 according to git blame
  • Drops type hints from signature in docs, as they are hard to read and redundant (we document everything anyway)
  • prettifies display of DefaultValue instances in signtures in docs
  • makes disable_notification default to None instead of False. That has the same effect, we pass less stuff to TG (and it simplified tests)
  • cleans up some foo = 'text' ' text continued' strings, probably leftovers from switching to black formatting

todo

  • overhaul tests to strictly test defaults
  • manually test stuff like answer_inline_query

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review February 9, 2021 21:30
@Bibo-Joshi
Copy link
Member Author

CI seems to work, finally :)

@Bibo-Joshi Bibo-Joshi added the 🛠 refactor change type: refactor label Feb 13, 2021
# Conflicts:
#	.github/workflows/test.yml
#	requirements.txt
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic looks fine to me!

@Bibo-Joshi Bibo-Joshi merged commit 2a4a0d0 into master Feb 19, 2021
@Bibo-Joshi Bibo-Joshi deleted the fix-2361 branch February 19, 2021 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 bug pr description: bug 🛠 refactor change type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG in v13.2] Shortcuts are overriding Defaults
3 participants