Skip to content

Conversation

jh0ker
Copy link
Member

@jh0ker jh0ker commented Jul 11, 2016

As pomised in #329

@jh0ker jh0ker added the 📋 pending-review work status: pending-review label Jul 11, 2016
string contains any % escapes requiring parameters, they should be specified as subsequent
arguments (it's just like printf!).

The client ip and current date/time are prefixed to every message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date/time is only prefixed when the user's logging configuration.
As discussed in a private chat, this line is probably copy pasted. Therefore a fix suggestion is to fix the 'and current date/time' part.

@MWeesenaar
Copy link
Contributor

Added two lines of comment on the PR.

  • Documentation is not entirely correct (expected output);
  • Added a suggestion for different string formatting in logging.

@MWeesenaar
Copy link
Contributor

LGTM!

@MWeesenaar MWeesenaar removed the 📋 pending-review work status: pending-review label Jul 12, 2016
@jh0ker jh0ker merged commit f0b2028 into master Jul 12, 2016
@jh0ker jh0ker deleted the silence-webhook-logging branch July 12, 2016 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants