Error in PDMIn filter loop.

dhalbert · tannewt · commit 2d2735c9d431 · 2017-12-21T13:59:16.000-08:00
diff --git a/atmel-samd/common-hal/audiobusio/PDMIn.c b/atmel-samd/common-hal/audiobusio/PDMIn.c
@@ -273,8 +273,9 @@ static uint16_t filter_sample(uint32_t pdm_samples[4]) {
         uint32_t pdm_sample = pdm_samples[i];
         REPEAT_16_TIMES( {
                 if (pdm_sample & 0x8000) {
-                    running_sum += *filter_ptr++;
+                    running_sum += *filter_ptr;
                 }
+                filter_ptr++;
                 pdm_sample <<= 1;
             }
             )

Original file line number	Diff line number	Diff line change
`@@ -273,8 +273,9 @@ static uint16_t filter_sample(uint32_t pdm_samples[4]) {`
`273`	`273`	`uint32_t pdm_sample = pdm_samples[i];`
`274`	`274`	`REPEAT_16_TIMES( {`
`275`	`275`	`if (pdm_sample & 0x8000) {`
`276`		`- running_sum += *filter_ptr++;`
	`276`	`+ running_sum += *filter_ptr;`
`277`	`277`	`}`
	`278`	`+ filter_ptr++;`
`278`	`279`	`pdm_sample <<= 1;`
`279`	`280`	`}`
`280`	`281`	`)`