atmel-samd: Update and enable neopixel_write for ASF4, tested on SAMD21 only.

tdicola · tdicola · commit d2320562a654 · 2017-10-10T16:56:59.000-07:00
diff --git a/atmel-samd/Makefile b/atmel-samd/Makefile
@@ -230,6 +230,7 @@ SRC_COMMON_HAL = \
 	microcontroller/__init__.c \
 	microcontroller/Pin.c \
 	microcontroller/Processor.c \
+	neopixel_write/__init__.c \
 	os/__init__.c \
 	time/__init__.c
 #	analogio/__init__.c \
diff --git a/atmel-samd/boards/circuitplayground_express/board.c b/atmel-samd/boards/circuitplayground_express/board.c
@@ -61,6 +61,6 @@ void reset_board(void) {
     common_hal_digitalio_digitalinout_construct(&neopixel_pin, &pin_PB23);
     common_hal_digitalio_digitalinout_switch_to_output(&neopixel_pin, false,
         DRIVE_MODE_PUSH_PULL);
-    // common_hal_neopixel_write(&neopixel_pin, empty, 30);
+    common_hal_neopixel_write(&neopixel_pin, empty, 30);
     common_hal_digitalio_digitalinout_deinit(&neopixel_pin);
 }
diff --git a/atmel-samd/common-hal/neopixel_write/__init__.c b/atmel-samd/common-hal/neopixel_write/__init__.c
@@ -23,13 +23,12 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
+#include "hpl_gpio.h"
 
-#include "mphalport.h"
+#include "py/mphal.h"
 
 #include "shared-bindings/neopixel_write/__init__.h"
 
-#include "asf/common2/services/delay/delay.h"
-#include "asf/sam0/drivers/port/port.h"
 
 void common_hal_neopixel_write(const digitalio_digitalinout_obj_t* digitalinout, uint8_t *pixels, uint32_t numBytes) {
     // This is adapted directly from the Adafruit NeoPixel library SAMD21G18A code:
@@ -45,7 +44,7 @@ void common_hal_neopixel_write(const digitalio_digitalinout_obj_t* digitalinout,
     NVMCTRL->CTRLB.bit.READMODE = NVMCTRL_CTRLB_READMODE_DETERMINISTIC_Val;
 
     uint32_t pin = digitalinout->pin->pin;
-    port    =  port_get_group_from_gpio_pin(pin);
+    port    =  &PORT->Group[GPIO_PORT(pin)];  // Convert GPIO # to port register
     pinMask =  (1UL << (pin % 32));  // From port_pin_set_output_level ASF code.
     ptr     =  pixels;
     end     =  ptr + numBytes;
@@ -83,5 +82,5 @@ void common_hal_neopixel_write(const digitalio_digitalinout_obj_t* digitalinout,
     // 50us delay to let pixels latch to the data that was just sent.
     // This could be optimized to only occur before pixel writes when necessary,
     // like in the Arduino library.
-    delay_us(50);
+    mp_hal_delay_us(50);
 }
diff --git a/atmel-samd/mpconfigport.h b/atmel-samd/mpconfigport.h
@@ -203,7 +203,6 @@ extern const struct _mp_obj_module_t usb_hid_module;
 // { MP_OBJ_NEW_QSTR(MP_QSTR_touchio), (mp_obj_t)&touchio_module },
 //    { MP_OBJ_NEW_QSTR(MP_QSTR_analogio), (mp_obj_t)&analogio_module },
 //    { MP_OBJ_NEW_QSTR(MP_QSTR_busio), (mp_obj_t)&busio_module },
-//    { MP_OBJ_NEW_QSTR(MP_QSTR_neopixel_write),(mp_obj_t)&neopixel_write_module },
 //    { MP_OBJ_NEW_QSTR(MP_QSTR_usb_hid),(mp_obj_t)&usb_hid_module },
 //    { MP_OBJ_NEW_QSTR(MP_QSTR_storage), (mp_obj_t)&storage_module },
 //    { MP_OBJ_NEW_QSTR(MP_QSTR_samd),(mp_obj_t)&samd_module },
@@ -213,6 +212,7 @@ extern const struct _mp_obj_module_t usb_hid_module;
     { MP_OBJ_NEW_QSTR(MP_QSTR_board), (mp_obj_t)&board_module }, \
     { MP_OBJ_NEW_QSTR(MP_QSTR_digitalio), (mp_obj_t)&digitalio_module }, \
     { MP_OBJ_NEW_QSTR(MP_QSTR_microcontroller), (mp_obj_t)&microcontroller_module }, \
+    { MP_OBJ_NEW_QSTR(MP_QSTR_neopixel_write),(mp_obj_t)&neopixel_write_module }, \
     { MP_OBJ_NEW_QSTR(MP_QSTR_os), (mp_obj_t)&os_module }, \
     { MP_OBJ_NEW_QSTR(MP_QSTR_random), (mp_obj_t)&random_module }, \
     { MP_OBJ_NEW_QSTR(MP_QSTR_time), (mp_obj_t)&time_module },

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,6 @@ void reset_board(void) {`
`61`	`61`	`common_hal_digitalio_digitalinout_construct(&neopixel_pin, &pin_PB23);`
`62`	`62`	`common_hal_digitalio_digitalinout_switch_to_output(&neopixel_pin, false,`
`63`	`63`	`DRIVE_MODE_PUSH_PULL);`
`64`		`- // common_hal_neopixel_write(&neopixel_pin, empty, 30);`
	`64`	`+ common_hal_neopixel_write(&neopixel_pin, empty, 30);`
`65`	`65`	`common_hal_digitalio_digitalinout_deinit(&neopixel_pin);`
`66`	`66`	`}`